Skip to content

Commit

Permalink
drm/i915: Assert that the transcoder is indeed off before modifying it
Browse files Browse the repository at this point in the history
Inspired by a recent regression that seems to confuse pch transcoder
state, let's be a bit more paranoid.

References: https://bugs.freedesktop.org/show_bug.cgi?id=49712
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
[danvet: Pimped commit message.]
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
  • Loading branch information
Chris Wilson authored and Daniel Vetter committed May 19, 2012
1 parent c14f528 commit e7e164d
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions drivers/gpu/drm/i915/intel_display.c
Original file line number Diff line number Diff line change
Expand Up @@ -2782,6 +2782,8 @@ static void ironlake_pch_enable(struct drm_crtc *crtc)
int pipe = intel_crtc->pipe;
u32 reg, temp;

assert_transcoder_disabled(dev_priv, pipe);

/* For PCH output, training FDI link */
dev_priv->display.fdi_link_train(crtc);

Expand Down

0 comments on commit e7e164d

Please sign in to comment.