Skip to content

Commit

Permalink
drbd: Endianness convert the constants instead of the variables
Browse files Browse the repository at this point in the history
Converting the constants happens at compile time.

Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
  • Loading branch information
Andreas Gruenbacher authored and Philipp Reisner committed Aug 25, 2011
1 parent ca9bc12 commit e7fad8a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion drivers/block/drbd/drbd_actlog.c
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,7 @@ static int drbd_al_read_tr(struct drbd_conf *mdev,
if (!drbd_md_sync_page_io(mdev, bdev, sector, READ))
return -1;

rv = (be32_to_cpu(b->magic) == DRBD_MAGIC);
rv = (b->magic == cpu_to_be32(DRBD_MAGIC));

for (i = 0; i < AL_EXTENTS_PT + 1; i++)
xor_sum ^= be32_to_cpu(b->updates[i].extent);
Expand Down
2 changes: 1 addition & 1 deletion drivers/block/drbd/drbd_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -3729,7 +3729,7 @@ int drbd_md_read(struct drbd_conf *mdev, struct drbd_backing_dev *bdev)
goto err;
}

if (be32_to_cpu(buffer->magic) != DRBD_MD_MAGIC) {
if (buffer->magic != cpu_to_be32(DRBD_MD_MAGIC)) {
dev_err(DEV, "Error while reading metadata, magic not found.\n");
rv = ERR_MD_INVALID;
goto err;
Expand Down

0 comments on commit e7fad8a

Please sign in to comment.