Skip to content

Commit

Permalink
sunrpc: assign PDE->data before gluing PDE into /proc tree
Browse files Browse the repository at this point in the history
Simply replace proc_create and further data assigned with proc_create_data.

Signed-off-by: Denis V. Lunev <den@openvz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Denis V. Lunev authored and David S. Miller committed May 2, 2008
1 parent fb65f18 commit e7fe233
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 16 deletions.
15 changes: 6 additions & 9 deletions net/sunrpc/cache.c
Original file line number Diff line number Diff line change
Expand Up @@ -316,31 +316,28 @@ static int create_cache_proc_entries(struct cache_detail *cd)
cd->proc_ent->owner = cd->owner;
cd->channel_ent = cd->content_ent = NULL;

p = proc_create("flush", S_IFREG|S_IRUSR|S_IWUSR,
cd->proc_ent, &cache_flush_operations);
p = proc_create_data("flush", S_IFREG|S_IRUSR|S_IWUSR,
cd->proc_ent, &cache_flush_operations, cd);
cd->flush_ent = p;
if (p == NULL)
goto out_nomem;
p->owner = cd->owner;
p->data = cd;

if (cd->cache_request || cd->cache_parse) {
p = proc_create("channel", S_IFREG|S_IRUSR|S_IWUSR,
cd->proc_ent, &cache_file_operations);
p = proc_create_data("channel", S_IFREG|S_IRUSR|S_IWUSR,
cd->proc_ent, &cache_file_operations, cd);
cd->channel_ent = p;
if (p == NULL)
goto out_nomem;
p->owner = cd->owner;
p->data = cd;
}
if (cd->cache_show) {
p = proc_create("content", S_IFREG|S_IRUSR|S_IWUSR,
cd->proc_ent, &content_file_operations);
p = proc_create_data("content", S_IFREG|S_IRUSR|S_IWUSR,
cd->proc_ent, &content_file_operations, cd);
cd->content_ent = p;
if (p == NULL)
goto out_nomem;
p->owner = cd->owner;
p->data = cd;
}
return 0;
out_nomem:
Expand Down
8 changes: 1 addition & 7 deletions net/sunrpc/stats.c
Original file line number Diff line number Diff line change
Expand Up @@ -224,16 +224,10 @@ EXPORT_SYMBOL_GPL(rpc_print_iostats);
static inline struct proc_dir_entry *
do_register(const char *name, void *data, const struct file_operations *fops)
{
struct proc_dir_entry *ent;

rpc_proc_init();
dprintk("RPC: registering /proc/net/rpc/%s\n", name);

ent = proc_create(name, 0, proc_net_rpc, fops);
if (ent) {
ent->data = data;
}
return ent;
return proc_create_data(name, 0, proc_net_rpc, fops, data);
}

struct proc_dir_entry *
Expand Down

0 comments on commit e7fe233

Please sign in to comment.