Skip to content

Commit

Permalink
[media] dvb_usb_v2: remove various unneeded variables
Browse files Browse the repository at this point in the history
Adapter priv is not really needed, use device priv instead.
There is only driver or two using that.

Device caps are not needed. There was only "has I2C adapter"
capability defined. It is useless as we can see same just
checking existence of i2c_algo callback.

And also remove some totally not used at all variables.

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Antti Palosaari authored and Mauro Carvalho Chehab committed Aug 4, 2012
1 parent 19ec272 commit e80e9af
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 23 deletions.
9 changes: 1 addition & 8 deletions drivers/media/dvb/dvb-usb/dvb_usb.h
Original file line number Diff line number Diff line change
Expand Up @@ -211,9 +211,6 @@ struct dvb_usb_device_properties {
struct module *owner;
short *adapter_nr;

#define DVB_USB_IS_AN_I2C_ADAPTER 0x01
int caps;

int size_of_priv;

const char *firmware;
Expand Down Expand Up @@ -330,8 +327,6 @@ struct dvb_usb_adapter {

int active_fe;
int num_frontends_initialized;

void *priv;
};

/**
Expand Down Expand Up @@ -379,16 +374,14 @@ struct dvb_usb_device {
struct mutex i2c_mutex;
struct i2c_adapter i2c_adap;

int num_adapters_initialized;
int num_adapters_initialized;
struct dvb_usb_adapter adapter[MAX_NO_OF_ADAPTER_PER_DEVICE];

/* remote control */
struct rc_dev *rc_dev;
struct input_dev *input_dev;
char rc_phys[64];
struct delayed_work rc_query_work;
u32 last_event;
int last_state;

void *priv;
};
Expand Down
7 changes: 1 addition & 6 deletions drivers/media/dvb/dvb-usb/dvb_usb_i2c.c
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,9 @@ int dvb_usb_i2c_init(struct dvb_usb_device *d)
{
int ret = 0;

if (!(d->props.caps & DVB_USB_IS_AN_I2C_ADAPTER))
if (!d->props.i2c_algo)
return 0;

if (d->props.i2c_algo == NULL) {
err("no i2c algorithm specified");
return -EINVAL;
}

strlcpy(d->i2c_adap.name, d->name, sizeof(d->i2c_adap.name));
d->i2c_adap.algo = d->props.i2c_algo;
d->i2c_adap.algo_data = NULL;
Expand Down
10 changes: 1 addition & 9 deletions drivers/media/dvb/dvb-usb/dvb_usb_init.c
Original file line number Diff line number Diff line change
Expand Up @@ -125,14 +125,6 @@ static int dvb_usb_adapter_init(struct dvb_usb_device *d)
adap->max_feed_count = adap->props.pid_filter_count;
}

if (adap->props.size_of_priv > 0) {
adap->priv = kzalloc(adap->props.size_of_priv, GFP_KERNEL);
if (adap->priv == NULL) {
err("no memory for priv for adapter %d.", n);
return -ENOMEM;
}
}

ret = dvb_usb_adapter_stream_init(adap);
if (ret)
return ret;
Expand Down Expand Up @@ -178,7 +170,7 @@ static int dvb_usb_adapter_exit(struct dvb_usb_device *d)
dvb_usb_adapter_frontend_exit(&d->adapter[n]);
dvb_usb_adapter_dvb_exit(&d->adapter[n]);
dvb_usb_adapter_stream_exit(&d->adapter[n]);
kfree(d->adapter[n].priv);

}
d->num_adapters_initialized = 0;
d->state &= ~DVB_USB_STATE_DVB;
Expand Down

0 comments on commit e80e9af

Please sign in to comment.