Skip to content

Commit

Permalink
[PATCH] ide: possible cleanups
Browse files Browse the repository at this point in the history
This patch contains the following possible cleanups:
- pci/cy82c693.c: make a needlessly global function static
- remove the following unneeded EXPORT_SYMBOL's:
  - ide-taskfile.c: do_rw_taskfile
  - ide-iops.c: default_hwif_iops
  - ide-iops.c: default_hwif_transport
  - ide-iops.c: wait_for_ready

Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
  • Loading branch information
Adrian Bunk authored and Bartlomiej Zolnierkiewicz committed Nov 9, 2005
1 parent 83ae20c commit e851b62
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 9 deletions.
6 changes: 0 additions & 6 deletions drivers/ide/ide-iops.c
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,6 @@ void default_hwif_iops (ide_hwif_t *hwif)
hwif->INSL = ide_insl;
}

EXPORT_SYMBOL(default_hwif_iops);

/*
* MMIO operations, typically used for SATA controllers
*/
Expand Down Expand Up @@ -329,8 +327,6 @@ void default_hwif_transport(ide_hwif_t *hwif)
hwif->atapi_output_bytes = atapi_output_bytes;
}

EXPORT_SYMBOL(default_hwif_transport);

/*
* Beginning of Taskfile OPCODE Library and feature sets.
*/
Expand Down Expand Up @@ -529,8 +525,6 @@ int wait_for_ready (ide_drive_t *drive, int timeout)
return 0;
}

EXPORT_SYMBOL(wait_for_ready);

/*
* This routine busy-waits for the drive status to be not "busy".
* It then checks the status for all of the "good" bits and none
Expand Down
2 changes: 0 additions & 2 deletions drivers/ide/ide-taskfile.c
Original file line number Diff line number Diff line change
Expand Up @@ -161,8 +161,6 @@ ide_startstop_t do_rw_taskfile (ide_drive_t *drive, ide_task_t *task)
return ide_stopped;
}

EXPORT_SYMBOL(do_rw_taskfile);

/*
* set_multmode_intr() is invoked on completion of a WIN_SETMULT cmd.
*/
Expand Down
2 changes: 1 addition & 1 deletion drivers/ide/pci/cy82c693.c
Original file line number Diff line number Diff line change
Expand Up @@ -469,7 +469,7 @@ static void __devinit init_hwif_cy82c693(ide_hwif_t *hwif)

static __devinitdata ide_hwif_t *primary;

void __devinit init_iops_cy82c693(ide_hwif_t *hwif)
static void __devinit init_iops_cy82c693(ide_hwif_t *hwif)
{
if (PCI_FUNC(hwif->pci_dev->devfn) == 1)
primary = hwif;
Expand Down

0 comments on commit e851b62

Please sign in to comment.