Skip to content

Commit

Permalink
[PATCH] VT binding: Make newport_con support binding
Browse files Browse the repository at this point in the history
- move register ioremap from newport_startup() to newport_console_init()
- fonts are freed multiple times, do it only once

Signed-off-by: Antonino Daplas <adaplas@pol.net>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Antonino A. Daplas authored and Linus Torvalds committed Jun 26, 2006
1 parent ac08dae commit e86bb8a
Showing 1 changed file with 28 additions and 10 deletions.
38 changes: 28 additions & 10 deletions drivers/video/console/newport_con.c
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ static int topscan;
static int xcurs_correction = 29;
static int newport_xsize;
static int newport_ysize;
static int newport_has_init;

static int newport_set_def_font(int unit, struct console_font *op);

Expand Down Expand Up @@ -283,15 +284,26 @@ static void newport_get_revisions(void)
xcurs_correction = 21;
}

static void newport_exit(void)
{
int i;

/* free memory used by user font */
for (i = 0; i < MAX_NR_CONSOLES; i++)
newport_set_def_font(i, NULL);
}

/* Can't be __init, take_over_console may call it later */
static const char *newport_startup(void)
{
int i;

if (!sgi_gfxaddr)
return NULL;
npregs = (struct newport_regs *) /* ioremap cannot fail */
ioremap(sgi_gfxaddr, sizeof(struct newport_regs));

if (!npregs)
npregs = (struct newport_regs *)/* ioremap cannot fail */
ioremap(sgi_gfxaddr, sizeof(struct newport_regs));
npregs->cset.config = NPORT_CFG_GD0;

if (newport_wait(npregs))
Expand All @@ -307,11 +319,11 @@ static const char *newport_startup(void)
newport_reset();
newport_get_revisions();
newport_get_screensize();
newport_has_init = 1;

return "SGI Newport";

out_unmap:
iounmap((void *)npregs);
return NULL;
}

Expand All @@ -324,11 +336,10 @@ static void newport_init(struct vc_data *vc, int init)

static void newport_deinit(struct vc_data *c)
{
int i;

/* free memory used by user font */
for (i = 0; i < MAX_NR_CONSOLES; i++)
newport_set_def_font(i, NULL);
if (!con_is_bound(&newport_con) && newport_has_init) {
newport_exit();
newport_has_init = 0;
}
}

static void newport_clear(struct vc_data *vc, int sy, int sx, int height,
Expand Down Expand Up @@ -728,16 +739,23 @@ const struct consw newport_con = {
#ifdef MODULE
static int __init newport_console_init(void)
{

if (!sgi_gfxaddr)
return NULL;

if (!npregs)
npregs = (struct newport_regs *)/* ioremap cannot fail */
ioremap(sgi_gfxaddr, sizeof(struct newport_regs));

return take_over_console(&newport_con, 0, MAX_NR_CONSOLES - 1, 1);
}
module_init(newport_console_init);

static void __exit newport_console_exit(void)
{
give_up_console(&newport_con);
iounmap((void *)npregs);
}

module_init(newport_console_init);
module_exit(newport_console_exit);
#endif

Expand Down

0 comments on commit e86bb8a

Please sign in to comment.