Skip to content

Commit

Permalink
NFSv4.1: Try to deal with NFS4ERR_SEQ_MISORDERED.
Browse files Browse the repository at this point in the history
If the server returns NFS4ERR_SEQ_MISORDERED, it could be a sign
that the slot was retired at some point. Retry the attempt after
reinitialising the slot sequence number to 1.

Also add a handler for NFS4ERR_SEQ_FALSE_RETRY. Just bump the slot
sequence number and retry...

Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
  • Loading branch information
Trond Myklebust authored and Trond Myklebust committed Dec 15, 2012
1 parent 65a0c14 commit e879444
Showing 1 changed file with 19 additions and 5 deletions.
24 changes: 19 additions & 5 deletions fs/nfs/nfs4proc.c
Original file line number Diff line number Diff line change
Expand Up @@ -467,11 +467,19 @@ static int nfs41_sequence_done(struct rpc_task *task, struct nfs4_sequence_res *
* The slot id we used was probably retired. Try again
* using a different slot id.
*/
if (rpc_restart_call_prepare(task)) {
task->tk_status = 0;
ret = 0;
}
break;
goto retry_nowait;
case -NFS4ERR_SEQ_MISORDERED:
/*
* Could this slot have been previously retired?
* If so, then the server may be expecting seq_nr = 1!
*/
if (slot->seq_nr == 1)
break;
slot->seq_nr = 1;
goto retry_nowait;
case -NFS4ERR_SEQ_FALSE_RETRY:
++slot->seq_nr;
goto retry_nowait;
default:
/* Just update the slot sequence no. */
++slot->seq_nr;
Expand All @@ -481,6 +489,12 @@ static int nfs41_sequence_done(struct rpc_task *task, struct nfs4_sequence_res *
dprintk("%s: Error %d free the slot \n", __func__, res->sr_status);
nfs41_sequence_free_slot(res);
return ret;
retry_nowait:
if (rpc_restart_call_prepare(task)) {
task->tk_status = 0;
ret = 0;
}
goto out;
out_retry:
if (!rpc_restart_call(task))
goto out;
Expand Down

0 comments on commit e879444

Please sign in to comment.