Skip to content

Commit

Permalink
video: pxa168fb: remove a redundant pxa168fb_check_var call
Browse files Browse the repository at this point in the history
Current implementation calls pxa168fb_check_var twice in pxa168fb_probe.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Signed-off-by: Paul Mundt <lethal@linux-sh.org>
  • Loading branch information
axel lin authored and Paul Mundt committed Jan 25, 2011
1 parent 360c202 commit e88e43b
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions drivers/video/pxa168fb.c
Original file line number Diff line number Diff line change
Expand Up @@ -701,16 +701,12 @@ static int __devinit pxa168fb_probe(struct platform_device *pdev)
*/
pxa168fb_init_mode(info, mi);

ret = pxa168fb_check_var(&info->var, info);
if (ret)
goto failed_free_fbmem;

/*
* Fill in sane defaults.
*/
ret = pxa168fb_check_var(&info->var, info);
if (ret)
goto failed;
goto failed_free_fbmem;

/*
* enable controller clock
Expand Down

0 comments on commit e88e43b

Please sign in to comment.