Skip to content

Commit

Permalink
Staging: me4000: kfree(NULL) is safe, so no extra checks needed.
Browse files Browse the repository at this point in the history
Signed-off-by: Andre Haupt <andre@bitwigglers.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Andre Haupt authored and Greg Kroah-Hartman committed Apr 3, 2009
1 parent 705d300 commit e8aa1bd
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions drivers/staging/me4000/me4000.c
Original file line number Diff line number Diff line change
Expand Up @@ -546,15 +546,13 @@ static void clear_board_info_list(void)
&board_info->ao_context_list, list) {
me4000_ao_reset(ao_context);
free_irq(ao_context->irq, ao_context);
if (ao_context->circ_buf.buf)
kfree(ao_context->circ_buf.buf);
kfree(ao_context->circ_buf.buf);
list_del(&ao_context->list);
kfree(ao_context);
}

/* Clear analog input context */
if (board_info->ai_context->circ_buf.buf)
kfree(board_info->ai_context->circ_buf.buf);
kfree(board_info->ai_context->circ_buf.buf);
kfree(board_info->ai_context);

/* Clear digital I/O context */
Expand Down Expand Up @@ -3668,8 +3666,7 @@ static int me4000_ai_config(struct me4000_ai_config *arg,
tmp &=
~(ME4000_AI_CTRL_BIT_CHANNEL_FIFO | ME4000_AI_CTRL_BIT_SAMPLE_HOLD);

if (list)
kfree(list);
kfree(list);

return err;

Expand Down

0 comments on commit e8aa1bd

Please sign in to comment.