Skip to content

Commit

Permalink
[PPC] minor irq handler cleanups
Browse files Browse the repository at this point in the history
- whitespace cleanups

- remove pointless prototype (uses always follow func implementation)

- 'irq' argument is used here purely as a local variable.  rename
  argument to 'dummy' and define 'irq' as local to make this plain.

Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Acked-by: Kumar Gala <galak@kernel.crashing.org>
  • Loading branch information
Jeff Garzik authored and Jeff Garzik committed Apr 20, 2008
1 parent 349a244 commit e8f3954
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
3 changes: 1 addition & 2 deletions arch/ppc/8xx_io/fec.c
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,6 @@ static int fec_enet_start_xmit(struct sk_buff *skb, struct net_device *dev);
#ifdef CONFIG_USE_MDIO
static void fec_enet_mii(struct net_device *dev);
#endif /* CONFIG_USE_MDIO */
static irqreturn_t fec_enet_interrupt(int irq, void * dev_id);
#ifdef CONFIG_FEC_PACKETHOOK
static void fec_enet_tx(struct net_device *dev, __u32 regval);
static void fec_enet_rx(struct net_device *dev, __u32 regval);
Expand Down Expand Up @@ -472,7 +471,7 @@ fec_timeout(struct net_device *dev)
* This is called from the MPC core interrupt.
*/
static irqreturn_t
fec_enet_interrupt(int irq, void * dev_id)
fec_enet_interrupt(int irq, void *dev_id)
{
struct net_device *dev = dev_id;
volatile fec_t *fecp;
Expand Down
4 changes: 3 additions & 1 deletion arch/ppc/platforms/sbc82xx.c
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,10 @@ struct hw_interrupt_type sbc82xx_i8259_ic = {
.end = sbc82xx_i8259_end_irq,
};

static irqreturn_t sbc82xx_i8259_demux(int irq, void *dev_id)
static irqreturn_t sbc82xx_i8259_demux(int dummy, void *dev_id)
{
int irq;

spin_lock(&sbc82xx_i8259_lock);

sbc82xx_i8259_map[0] = 0x0c; /* OCW3: Read IR register on RD# pulse */
Expand Down

0 comments on commit e8f3954

Please sign in to comment.