Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 176250
b: refs/heads/master
c: 4faf8d9
h: refs/heads/master
v: v3
  • Loading branch information
Lee Schermerhorn authored and Linus Torvalds committed Dec 15, 2009
1 parent 9bd23cd commit e90335f
Show file tree
Hide file tree
Showing 3 changed files with 51 additions and 7 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 8fe23e057172223fe2048768a4d87ab7de7477bc
refs/heads/master: 4faf8d950ec438c49ae4526b897c30f8a2cad741
3 changes: 2 additions & 1 deletion trunk/Documentation/vm/hugetlbpage.txt
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,8 @@ resulting effect on persistent huge page allocation is as follows:
Per Node Hugepages Attributes

A subset of the contents of the root huge page control directory in sysfs,
described above, has been replicated under each "node" system device in:
described above, will be replicated under each the system device of each
NUMA node with memory in:

/sys/devices/system/node/node[0-9]*/hugepages/

Expand Down
53 changes: 48 additions & 5 deletions trunk/drivers/base/node.c
Original file line number Diff line number Diff line change
Expand Up @@ -177,8 +177,8 @@ static SYSDEV_ATTR(distance, S_IRUGO, node_read_distance, NULL);
/*
* hugetlbfs per node attributes registration interface:
* When/if hugetlb[fs] subsystem initializes [sometime after this module],
* it will register its per node attributes for all nodes online at that
* time. It will also call register_hugetlbfs_with_node(), below, to
* it will register its per node attributes for all online nodes with
* memory. It will also call register_hugetlbfs_with_node(), below, to
* register its attribute registration functions with this node driver.
* Once these hooks have been initialized, the node driver will call into
* the hugetlb module to [un]register attributes for hot-plugged nodes.
Expand All @@ -188,7 +188,8 @@ static node_registration_func_t __hugetlb_unregister_node;

static inline void hugetlb_register_node(struct node *node)
{
if (__hugetlb_register_node)
if (__hugetlb_register_node &&
node_state(node->sysdev.id, N_HIGH_MEMORY))
__hugetlb_register_node(node);
}

Expand Down Expand Up @@ -233,6 +234,7 @@ int register_node(struct node *node, int num, struct node *parent)
sysdev_create_file(&node->sysdev, &attr_distance);

scan_unevictable_register_node(node);

hugetlb_register_node(node);
}
return error;
Expand All @@ -254,7 +256,7 @@ void unregister_node(struct node *node)
sysdev_remove_file(&node->sysdev, &attr_distance);

scan_unevictable_unregister_node(node);
hugetlb_unregister_node(node);
hugetlb_unregister_node(node); /* no-op, if memoryless node */

sysdev_unregister(&node->sysdev);
}
Expand Down Expand Up @@ -384,8 +386,45 @@ static int link_mem_sections(int nid)
}
return err;
}

/*
* Handle per node hstate attribute [un]registration on transistions
* to/from memoryless state.
*/

static int node_memory_callback(struct notifier_block *self,
unsigned long action, void *arg)
{
struct memory_notify *mnb = arg;
int nid = mnb->status_change_nid;

switch (action) {
case MEM_ONLINE: /* memory successfully brought online */
if (nid != NUMA_NO_NODE)
hugetlb_register_node(&node_devices[nid]);
break;
case MEM_OFFLINE: /* or offline */
if (nid != NUMA_NO_NODE)
hugetlb_unregister_node(&node_devices[nid]);
break;
case MEM_GOING_ONLINE:
case MEM_GOING_OFFLINE:
case MEM_CANCEL_ONLINE:
case MEM_CANCEL_OFFLINE:
default:
break;
}

return NOTIFY_OK;
}
#else
static int link_mem_sections(int nid) { return 0; }

static inline int node_memory_callback(struct notifier_block *self,
unsigned long action, void *arg)
{
return NOTIFY_OK;
}
#endif /* CONFIG_MEMORY_HOTPLUG_SPARSE */

int register_one_node(int nid)
Expand Down Expand Up @@ -499,13 +538,17 @@ static int node_states_init(void)
return err;
}

#define NODE_CALLBACK_PRI 2 /* lower than SLAB */
static int __init register_node_type(void)
{
int ret;

ret = sysdev_class_register(&node_class);
if (!ret)
if (!ret) {
ret = node_states_init();
hotplug_memory_notifier(node_memory_callback,
NODE_CALLBACK_PRI);
}

/*
* Note: we're not going to unregister the node class if we fail
Expand Down

0 comments on commit e90335f

Please sign in to comment.