Skip to content

Commit

Permalink
ipvs: Explictly clear ip_vs_stats members
Browse files Browse the repository at this point in the history
In order to align the coding styles of ip_vs_zero_stats() and
its child-function ip_vs_zero_estimator(), clear ip_vs_stats
members explicitlty rather than doing a limited memset().

This was chosen over modifying ip_vs_zero_estimator() to use
memset() as it is more robust against changes in members
in the relevant structures. memset() would be prefered if
all members of the structure were to be cleared.

Cc: Sven Wegener <sven.wegener@stealer.net>
Signed-off-by: Simon Horman <horms@verge.net.au>
Signed-off-by: Sven Wegener <sven.wegener@stealer.net>
  • Loading branch information
Simon Horman authored and Sven Wegener committed Aug 11, 2008
1 parent 519e49e commit e93615d
Showing 1 changed file with 14 additions and 1 deletion.
15 changes: 14 additions & 1 deletion net/ipv4/ipvs/ip_vs_ctl.c
Original file line number Diff line number Diff line change
Expand Up @@ -683,8 +683,21 @@ static void
ip_vs_zero_stats(struct ip_vs_stats *stats)
{
spin_lock_bh(&stats->lock);
memset(stats, 0, (char *)&stats->lock - (char *)stats);

stats->conns = 0;
stats->inpkts = 0;
stats->outpkts = 0;
stats->inbytes = 0;
stats->outbytes = 0;

stats->cps = 0;
stats->inpps = 0;
stats->outpps = 0;
stats->inbps = 0;
stats->outbps = 0;

ip_vs_zero_estimator(stats);

spin_unlock_bh(&stats->lock);
}

Expand Down

0 comments on commit e93615d

Please sign in to comment.