Skip to content

Commit

Permalink
cxgb3: fix link flap
Browse files Browse the repository at this point in the history
The driver is expected to report that the link is up
when the phy Rx signal is established and the mac
has not detected a link fault.
The code is however broken, the driver does not check the link fault
status when the phy link status changes.
The link fault status being checked within a short period of time,
it leads to link up/link down events.

Signed-off-by: Divy Le Ray <divy@chelsio.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Divy Le Ray authored and David S. Miller committed Feb 16, 2010
1 parent 38a8fc0 commit e9449d8
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion drivers/net/cxgb3/t3_hw.c
Original file line number Diff line number Diff line change
Expand Up @@ -1262,7 +1262,8 @@ void t3_link_changed(struct adapter *adapter, int port_id)
lc->fc = fc;
}

t3_os_link_changed(adapter, port_id, link_ok, speed, duplex, fc);
t3_os_link_changed(adapter, port_id, link_ok && !pi->link_fault,
speed, duplex, fc);
}

void t3_link_fault(struct adapter *adapter, int port_id)
Expand Down

0 comments on commit e9449d8

Please sign in to comment.