Skip to content

Commit

Permalink
USB: mos7720, mos7840: remove redundant urb check
Browse files Browse the repository at this point in the history
Coverity (1709, 1710, 1711, 1712, 1713) actually flagged these as
REVERSE_INULLs (NULL check performed after dereference). But looking at
the other drivers I can't see any similar tests and the USB core already
makes sure urb is non-null - so might as well get rid of the checks.


Signed-off-by: Florin Malita <fmalita@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Florin Malita authored and Greg Kroah-Hartman committed Jul 20, 2007
1 parent 195af2c commit e94fa28
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 24 deletions.
5 changes: 0 additions & 5 deletions drivers/usb/serial/mos7720.c
Original file line number Diff line number Diff line change
Expand Up @@ -110,11 +110,6 @@ static void mos7720_interrupt_callback(struct urb *urb)

dbg("%s"," : Entering\n");

if (!urb) {
dbg("%s","Invalid Pointer !!!!:\n");
return;
}

switch (status) {
case 0:
/* success */
Expand Down
19 changes: 0 additions & 19 deletions drivers/usb/serial/mos7840.c
Original file line number Diff line number Diff line change
Expand Up @@ -436,11 +436,6 @@ static void mos7840_control_callback(struct urb *urb)
int result = 0;
int status = urb->status;

if (!urb) {
dbg("%s", "Invalid Pointer !!!!:\n");
return;
}

mos7840_port = (struct moschip_port *)urb->context;

switch (status) {
Expand Down Expand Up @@ -525,10 +520,6 @@ static void mos7840_interrupt_callback(struct urb *urb)
int status = urb->status;

dbg("%s", " : Entering\n");
if (!urb) {
dbg("%s", "Invalid Pointer !!!!:\n");
return;
}

switch (status) {
case 0:
Expand Down Expand Up @@ -676,11 +667,6 @@ static void mos7840_bulk_in_callback(struct urb *urb)
struct tty_struct *tty;
int status = urb->status;

if (!urb) {
dbg("%s", "Invalid Pointer !!!!:\n");
return;
}

if (status) {
dbg("nonzero read bulk status received: %d", status);
return;
Expand Down Expand Up @@ -753,11 +739,6 @@ static void mos7840_bulk_out_data_callback(struct urb *urb)
int status = urb->status;
int i;

if (!urb) {
dbg("%s", "Invalid Pointer !!!!:\n");
return;
}

mos7840_port = (struct moschip_port *)urb->context;
spin_lock(&mos7840_port->pool_lock);
for (i = 0; i < NUM_URBS; i++) {
Expand Down

0 comments on commit e94fa28

Please sign in to comment.