Skip to content

Commit

Permalink
fuse: duplicate ->connected in pqueue
Browse files Browse the repository at this point in the history
This will allow checking ->connected just with the processing queue lock.

Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
Reviewed-by: Ashish Samant <ashish.samant@oracle.com>
  • Loading branch information
Miklos Szeredi committed Jul 1, 2015
1 parent 3a2b5b9 commit e96edd9
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 3 deletions.
7 changes: 4 additions & 3 deletions fs/fuse/dev.c
Original file line number Diff line number Diff line change
Expand Up @@ -1303,7 +1303,7 @@ static ssize_t fuse_dev_do_read(struct fuse_conn *fc, struct file *file,
fuse_copy_finish(cs);
spin_lock(&fc->lock);
clear_bit(FR_LOCKED, &req->flags);
if (!fc->connected) {
if (!fpq->connected) {
request_end(fc, req);
return -ENODEV;
}
Expand Down Expand Up @@ -1891,7 +1891,7 @@ static ssize_t fuse_dev_do_write(struct fuse_conn *fc,

spin_lock(&fc->lock);
err = -ENOENT;
if (!fc->connected)
if (!fpq->connected)
goto err_unlock;

req = request_find(fpq, oh.unique);
Expand Down Expand Up @@ -1928,7 +1928,7 @@ static ssize_t fuse_dev_do_write(struct fuse_conn *fc,

spin_lock(&fc->lock);
clear_bit(FR_LOCKED, &req->flags);
if (!fc->connected)
if (!fpq->connected)
err = -ENOENT;
else if (err)
req->out.h.error = -EIO;
Expand Down Expand Up @@ -2125,6 +2125,7 @@ void fuse_abort_conn(struct fuse_conn *fc)
fc->connected = 0;
fc->blocked = 0;
fuse_set_initialized(fc);
fpq->connected = 0;
list_for_each_entry_safe(req, next, &fpq->io, list) {
req->out.h.error = -ECONNABORTED;
spin_lock(&req->waitq.lock);
Expand Down
3 changes: 3 additions & 0 deletions fs/fuse/fuse_i.h
Original file line number Diff line number Diff line change
Expand Up @@ -402,6 +402,9 @@ struct fuse_iqueue {
};

struct fuse_pqueue {
/** Connection established */
unsigned connected;

/** The list of requests being processed */
struct list_head processing;

Expand Down
1 change: 1 addition & 0 deletions fs/fuse/inode.c
Original file line number Diff line number Diff line change
Expand Up @@ -582,6 +582,7 @@ static void fuse_pqueue_init(struct fuse_pqueue *fpq)
memset(fpq, 0, sizeof(struct fuse_pqueue));
INIT_LIST_HEAD(&fpq->processing);
INIT_LIST_HEAD(&fpq->io);
fpq->connected = 1;
}

void fuse_conn_init(struct fuse_conn *fc)
Expand Down

0 comments on commit e96edd9

Please sign in to comment.