Skip to content

Commit

Permalink
spi/mpc8xxx: don't check platform_get_irq's return value against zero
Browse files Browse the repository at this point in the history
platform_get_irq returns -ENXIO on failure, so !irq was probably
always true.  Make irq a signed variable and compare irq <= 0.  Note
that a return value of zero is still handled as error even though this
could mean irq0.

This is a followup to 305b322 that
changed the return value of platform_get_irq from 0 to -ENXIO on error.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Anton Vorontsov <avorontsov@ru.mvista.com>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
  • Loading branch information
Uwe Kleine-König authored and Grant Likely committed Jan 20, 2010
1 parent 34b8c66 commit e9a172f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/spi/spi_mpc8xxx.c
Original file line number Diff line number Diff line change
Expand Up @@ -1328,7 +1328,7 @@ static struct of_platform_driver of_mpc8xxx_spi_driver = {
static int __devinit plat_mpc8xxx_spi_probe(struct platform_device *pdev)
{
struct resource *mem;
unsigned int irq;
int irq;
struct spi_master *master;

if (!pdev->dev.platform_data)
Expand All @@ -1339,7 +1339,7 @@ static int __devinit plat_mpc8xxx_spi_probe(struct platform_device *pdev)
return -EINVAL;

irq = platform_get_irq(pdev, 0);
if (!irq)
if (irq <= 0)
return -EINVAL;

master = mpc8xxx_spi_probe(&pdev->dev, mem, irq);
Expand Down

0 comments on commit e9a172f

Please sign in to comment.