Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 10084
b: refs/heads/master
c: 3de463c
h: refs/heads/master
v: v3
  • Loading branch information
Oleg Nesterov authored and Linus Torvalds committed Oct 24, 2005
1 parent 295d6ad commit e9a6c02
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 27 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 108150ea78003044e41150c75259447b2c0953b6
refs/heads/master: 3de463c7d9d58f8cf3395268230cb20a4c15bffa
8 changes: 0 additions & 8 deletions trunk/kernel/exit.c
Original file line number Diff line number Diff line change
Expand Up @@ -825,14 +825,6 @@ fastcall NORET_TYPE void do_exit(long code)

tsk->flags |= PF_EXITING;

/*
* Make sure we don't try to process any timer firings
* while we are already exiting.
*/
tsk->it_virt_expires = cputime_zero;
tsk->it_prof_expires = cputime_zero;
tsk->it_sched_expires = 0;

if (unlikely(in_atomic()))
printk(KERN_INFO "note: %s[%d] exited with preempt_count %d\n",
current->comm, current->pid,
Expand Down
36 changes: 18 additions & 18 deletions trunk/kernel/posix-cpu-timers.c
Original file line number Diff line number Diff line change
Expand Up @@ -1285,30 +1285,30 @@ void run_posix_cpu_timers(struct task_struct *tsk)

#undef UNEXPIRED

BUG_ON(tsk->exit_state);

/*
* Double-check with locks held.
*/
read_lock(&tasklist_lock);
spin_lock(&tsk->sighand->siglock);
if (likely(tsk->signal != NULL)) {
spin_lock(&tsk->sighand->siglock);

/*
* Here we take off tsk->cpu_timers[N] and tsk->signal->cpu_timers[N]
* all the timers that are firing, and put them on the firing list.
*/
check_thread_timers(tsk, &firing);
check_process_timers(tsk, &firing);
/*
* Here we take off tsk->cpu_timers[N] and tsk->signal->cpu_timers[N]
* all the timers that are firing, and put them on the firing list.
*/
check_thread_timers(tsk, &firing);
check_process_timers(tsk, &firing);

/*
* We must release these locks before taking any timer's lock.
* There is a potential race with timer deletion here, as the
* siglock now protects our private firing list. We have set
* the firing flag in each timer, so that a deletion attempt
* that gets the timer lock before we do will give it up and
* spin until we've taken care of that timer below.
*/
spin_unlock(&tsk->sighand->siglock);
/*
* We must release these locks before taking any timer's lock.
* There is a potential race with timer deletion here, as the
* siglock now protects our private firing list. We have set
* the firing flag in each timer, so that a deletion attempt
* that gets the timer lock before we do will give it up and
* spin until we've taken care of that timer below.
*/
spin_unlock(&tsk->sighand->siglock);
}
read_unlock(&tasklist_lock);

/*
Expand Down

0 comments on commit e9a6c02

Please sign in to comment.