Skip to content

Commit

Permalink
[SCSI] initio: Fix merge fallout
Browse files Browse the repository at this point in the history
Fix IRQ reporting - just assign the ->pci_dev pointer earlier and use the
pci_dev irq field rather than keeping a private one

Init the spinlock as it works better on SMP that way

Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
  • Loading branch information
Alan Cox authored and James Bottomley committed Oct 18, 2007
1 parent 0fec02c commit e9e42fa
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions drivers/scsi/initio.c
Original file line number Diff line number Diff line change
Expand Up @@ -665,7 +665,7 @@ static void initio_init(struct initio_host * host, u8 *bios_addr)
host->max_tags[i] = 0xFF;
} /* for */
printk("i91u: PCI Base=0x%04X, IRQ=%d, BIOS=0x%04X0, SCSI ID=%d\n",
host->addr, host->irq,
host->addr, host->pci_dev->irq,
host->bios_addr, host->scsi_id);
/* Reset SCSI Bus */
if (host->config & HCC_SCSI_RESET) {
Expand Down Expand Up @@ -2891,6 +2891,8 @@ static int initio_probe_one(struct pci_dev *pdev,
goto out_release_region;
}

host->pci_dev = pdev;

host->num_scbs = num_scb;
host->scb = scb;
host->next_pending = scb;
Expand All @@ -2905,6 +2907,7 @@ static int initio_probe_one(struct pci_dev *pdev,
host->scb_end = tmp;
host->first_avail = scb;
host->last_avail = prev;
spin_lock_init(&host->avail_lock);

initio_init(host, phys_to_virt(bios_seg << 4));

Expand All @@ -2928,7 +2931,6 @@ static int initio_probe_one(struct pci_dev *pdev,
}

pci_set_drvdata(pdev, shost);
host->pci_dev = pdev;

error = scsi_add_host(shost, &pdev->dev);
if (error)
Expand Down

0 comments on commit e9e42fa

Please sign in to comment.