---

yaml --- r: 168753 b: refs/heads/master c: 91e9c07 h: refs/heads/master i: 168751: 1f8f32d v: v3
git-mirror · Nov 16, 2009 · e9fb9ec · e9fb9ec
1 parent cb20a08
commit e9fb9ec
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/[refs] b/[refs]
@@ -1,2 +1,2 @@
 ---
-refs/heads/master: e29d4363174949a7a4e46f670993d7ff43342c1c
+refs/heads/master: 91e9c07bd635353d1a278bdb38dbb56ac371bcb8
diff --git a/trunk/net/core/dev.c b/trunk/net/core/dev.c
@@ -942,14 +942,15 @@ int dev_change_name(struct net_device *dev, const char *newname)
 	ret = notifier_to_errno(ret);
 
 	if (ret) {
-		if (err) {
-			printk(KERN_ERR
-			       "%s: name change rollback failed: %d.\n",
-			       dev->name, ret);
-		} else {
+		/* err >= 0 after dev_alloc_name() or stores the first errno */
+		if (err >= 0) {
 			err = ret;
 			memcpy(dev->name, oldname, IFNAMSIZ);
 			goto rollback;
+		} else {
+			printk(KERN_ERR
+			       "%s: name change rollback failed: %d.\n",
+			       dev->name, ret);
 		}
 	}