Skip to content

Commit

Permalink
PCI: keystone: Fix error handling of irq_of_parse_and_map()
Browse files Browse the repository at this point in the history
Return value of irq_of_parse_and_map() is unsigned int, with 0 indicating
failure, so testing for negative result never works.

Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-By: Murali Karicheri <m-karicheri2@ti.com>
  • Loading branch information
Dmitry Torokhov authored and Bjorn Helgaas committed Dec 26, 2014
1 parent 97bf6af commit ea3651f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/pci/host/pci-keystone.c
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ static int ks_pcie_get_irq_controller_info(struct keystone_pcie *ks_pcie,
*/
for (temp = 0; temp < max_host_irqs; temp++) {
host_irqs[temp] = irq_of_parse_and_map(*np_temp, temp);
if (host_irqs[temp] < 0)
if (!host_irqs[temp])
break;
}
if (temp) {
Expand Down

0 comments on commit ea3651f

Please sign in to comment.