Skip to content

Commit

Permalink
[media] siano: apply debug flag to module level
Browse files Browse the repository at this point in the history
Siano modules already had sms_dbg flag which is a module parameter which
sets the debug mode so module prints messages to dmesg for debugging.
The variable was static therefore apply only to the file which defines
the module. In modules as smsmdtv.ko that contain a few files, the debug
flag applied only for functions in that main file.
flag was changed to be non-static and therefore can be accessed by all
module files (although it is still not exported out of the module).

Signed-off-by: Doron Cohen <doronc@siano-ms.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Doron Cohen authored and Mauro Carvalho Chehab committed Aug 27, 2011
1 parent fda516b commit ea37094
Show file tree
Hide file tree
Showing 5 changed files with 2 additions and 13 deletions.
4 changes: 0 additions & 4 deletions drivers/media/dvb/siano/sms-cards.c
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,6 @@
#include "sms-cards.h"
#include "smsir.h"

static int sms_dbg;
module_param_named(cards_dbg, sms_dbg, int, 0644);
MODULE_PARM_DESC(cards_dbg, "set debug level (info=1, adv=2 (or-able))");

static struct sms_board sms_boards[] = {
[SMS_BOARD_UNKNOWN] = {
.name = "Unknown board",
Expand Down
2 changes: 1 addition & 1 deletion drivers/media/dvb/siano/smscoreapi.c
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
#include "smsir.h"
#include "smsendian.h"

static int sms_dbg;
int sms_dbg;
module_param_named(debug, sms_dbg, int, 0644);
MODULE_PARM_DESC(debug, "set debug level (info=1, adv=2 (or-able))");

Expand Down
1 change: 1 addition & 0 deletions drivers/media/dvb/siano/smscoreapi.h
Original file line number Diff line number Diff line change
Expand Up @@ -751,6 +751,7 @@ int smscore_led_state(struct smscore_device_t *core, int led);


/* ------------------------------------------------------------------------ */
extern int sms_dbg;

#define DBG_INFO 1
#define DBG_ADV 2
Expand Down
4 changes: 0 additions & 4 deletions drivers/media/dvb/siano/smsdvb.c
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,6 @@ struct smsdvb_client_t {
static struct list_head g_smsdvb_clients;
static struct mutex g_smsdvb_clientslock;

static int sms_dbg;
module_param_named(debug, sms_dbg, int, 0644);
MODULE_PARM_DESC(debug, "set debug level (info=1, adv=2 (or-able))");

/* Events that may come from DVB v3 adapter */
static void sms_board_dvb3_event(struct smsdvb_client_t *client,
enum SMS_DVB3_EVENTS event) {
Expand Down
4 changes: 0 additions & 4 deletions drivers/media/dvb/siano/smsusb.c
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#include "sms-cards.h"
#include "smsendian.h"

static int sms_dbg;
module_param_named(debug, sms_dbg, int, 0644);
MODULE_PARM_DESC(debug, "set debug level (info=1, adv=2 (or-able))");

#define USB1_BUFFER_SIZE 0x1000
#define USB2_BUFFER_SIZE 0x4000

Expand Down

0 comments on commit ea37094

Please sign in to comment.