Skip to content

Commit

Permalink
regulator: core: Change the unit of ramp_delay from mV/uS to uV/uS
Browse files Browse the repository at this point in the history
This change makes it possible to set ramp_delay with 0.xxx mV/uS without
truncation issue.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
  • Loading branch information
Axel Lin authored and Mark Brown committed Jun 18, 2012
1 parent 398715a commit ea38d13
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion Documentation/devicetree/bindings/regulator/regulator.txt
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Optional properties:
- regulator-always-on: boolean, regulator should never be disabled
- regulator-boot-on: bootloader/firmware enabled regulator
- <name>-supply: phandle to the parent supply/regulator node
- regulator-ramp-delay: ramp delay for regulator(in mV/uS)
- regulator-ramp-delay: ramp delay for regulator(in uV/uS)

Example:

Expand Down
4 changes: 2 additions & 2 deletions drivers/regulator/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -2319,11 +2319,11 @@ int regulator_set_voltage_time_sel(struct regulator_dev *rdev,
if (rdev->desc->uV_step) {
return DIV_ROUND_UP(rdev->desc->uV_step *
abs(new_selector - old_selector),
ramp_delay * 1000);
ramp_delay);
} else if (rdev->desc->volt_table) {
return DIV_ROUND_UP(abs(rdev->desc->volt_table[new_selector] -
rdev->desc->volt_table[old_selector]),
ramp_delay * 1000);
ramp_delay);
} else {
rdev_warn(rdev, "Unsupported voltage mapping settings\n");
}
Expand Down
2 changes: 1 addition & 1 deletion include/linux/regulator/driver.h
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ enum regulator_type {
*
* @min_uV: Voltage given by the lowest selector (if linear mapping)
* @uV_step: Voltage increase with each selector (if linear mapping)
* @ramp_delay: Time to settle down after voltage change (unit: mV/us)
* @ramp_delay: Time to settle down after voltage change (unit: uV/us)
* @volt_table: Voltage mapping table (if table based mapping)
*
* @vsel_reg: Register for selector when using regulator_regmap_X_voltage_
Expand Down
2 changes: 1 addition & 1 deletion include/linux/regulator/machine.h
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ struct regulator_state {
* mode.
* @initial_state: Suspend state to set by default.
* @initial_mode: Mode to set at startup.
* @ramp_delay: Time to settle down after voltage change (unit: mV/us)
* @ramp_delay: Time to settle down after voltage change (unit: uV/us)
*/
struct regulation_constraints {

Expand Down

0 comments on commit ea38d13

Please sign in to comment.