Skip to content

Commit

Permalink
clocksource: sunxi: make use of CLKSRC_OF
Browse files Browse the repository at this point in the history
Using CLKSRC_OF allows to remove the SoC specific sunxi_timer.h header,
and instead of using a custom init function in the machine definition
use the standard clocksource_of_init function.

Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
  • Loading branch information
Maxime Ripard committed Apr 8, 2013
1 parent 0498173 commit ea71d9a
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 41 deletions.
1 change: 1 addition & 0 deletions arch/arm/mach-sunxi/Kconfig
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
config ARCH_SUNXI
bool "Allwinner A1X SOCs" if ARCH_MULTI_V7
select CLKSRC_MMIO
select CLKSRC_OF
select COMMON_CLK
select GENERIC_CLOCKEVENTS
select GENERIC_IRQ_CHIP
Expand Down
11 changes: 9 additions & 2 deletions arch/arm/mach-sunxi/sunxi.c
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,16 @@
* warranty of any kind, whether express or implied.
*/

#include <linux/clocksource.h>
#include <linux/delay.h>
#include <linux/kernel.h>
#include <linux/init.h>
#include <linux/of_address.h>
#include <linux/of_irq.h>
#include <linux/of_platform.h>
#include <linux/io.h>
#include <linux/sunxi_timer.h>

#include <linux/clk/sunxi.h>
#include <linux/irqchip/sunxi.h>

#include <asm/mach/arch.h>
Expand Down Expand Up @@ -81,6 +82,12 @@ void __init sunxi_map_io(void)
iotable_init(sunxi_io_desc, ARRAY_SIZE(sunxi_io_desc));
}

static void __init sunxi_timer_init(void)
{
sunxi_init_clocks();
clocksource_of_init();
}

static void __init sunxi_dt_init(void)
{
sunxi_setup_restart();
Expand All @@ -100,6 +107,6 @@ DT_MACHINE_START(SUNXI_DT, "Allwinner A1X (Device Tree)")
.init_irq = sunxi_init_irq,
.handle_irq = sunxi_handle_irq,
.restart = sunxi_restart,
.init_time = &sunxi_timer_init,
.init_time = sunxi_timer_init,
.dt_compat = sunxi_board_dt_compat,
MACHINE_END
18 changes: 3 additions & 15 deletions drivers/clocksource/sunxi_timer.c
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@
#include <linux/of.h>
#include <linux/of_address.h>
#include <linux/of_irq.h>
#include <linux/sunxi_timer.h>
#include <linux/clk/sunxi.h>

#define TIMER_IRQ_EN_REG 0x00
#define TIMER_IRQ_EN(val) (1 << val)
Expand Down Expand Up @@ -98,23 +96,13 @@ static struct irqaction sunxi_timer_irq = {
.dev_id = &sunxi_clockevent,
};

static struct of_device_id sunxi_timer_dt_ids[] = {
{ .compatible = "allwinner,sunxi-timer" },
{ }
};

void __init sunxi_timer_init(void)
static void __init sunxi_timer_init(struct device_node *node)
{
struct device_node *node;
unsigned long rate = 0;
struct clk *clk;
int ret, irq;
u32 val;

node = of_find_matching_node(NULL, sunxi_timer_dt_ids);
if (!node)
panic("No sunxi timer node");

timer_base = of_iomap(node, 0);
if (!timer_base)
panic("Can't map registers");
Expand All @@ -123,8 +111,6 @@ void __init sunxi_timer_init(void)
if (irq <= 0)
panic("Can't parse IRQ");

sunxi_init_clocks();

clk = of_clk_get(node, 0);
if (IS_ERR(clk))
panic("Can't get timer clock");
Expand Down Expand Up @@ -158,3 +144,5 @@ void __init sunxi_timer_init(void)
clockevents_config_and_register(&sunxi_clockevent, rate / TIMER_SCAL,
0x1, 0xff);
}
CLOCKSOURCE_OF_DECLARE(sunxi, "allwinner,sunxi-timer",
sunxi_timer_init);
24 changes: 0 additions & 24 deletions include/linux/sunxi_timer.h

This file was deleted.

0 comments on commit ea71d9a

Please sign in to comment.