Skip to content

Commit

Permalink
parisc: kernel: using strlcpy() instead of strcpy()
Browse files Browse the repository at this point in the history
'boot_args' is an input args, and 'boot_command_line' has a fix length.
So use strlcpy() instead of strcpy() to avoid memory overflow.

Signed-off-by: Chen Gang <gang.chen@asianux.com>
Acked-by: Kyle McMartin <kyle@mcmartin.ca>
Signed-off-by: Helge Deller <deller@gmx.de>
  • Loading branch information
Chen Gang authored and Helge Deller committed Jun 1, 2013
1 parent 7660390 commit ea99b1a
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion arch/parisc/kernel/setup.c
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,8 @@ void __init setup_cmdline(char **cmdline_p)
/* called from hpux boot loader */
boot_command_line[0] = '\0';
} else {
strcpy(boot_command_line, (char *)__va(boot_args[1]));
strlcpy(boot_command_line, (char *)__va(boot_args[1]),
COMMAND_LINE_SIZE);

#ifdef CONFIG_BLK_DEV_INITRD
if (boot_args[2] != 0) /* did palo pass us a ramdisk? */
Expand Down

0 comments on commit ea99b1a

Please sign in to comment.