Skip to content

Commit

Permalink
svc: Make svc_sock_release svc_xprt_release
Browse files Browse the repository at this point in the history
The svc_sock_release function only touches transport independent fields.
Change the function to manipulate svc_xprt directly instead of the transport
dependent svc_sock structure.

Signed-off-by: Tom Tucker <tom@opengridcomputing.com>
Acked-by: Neil Brown <neilb@suse.de>
Reviewed-by: Chuck Lever <chuck.lever@oracle.com>
Reviewed-by: Greg Banks <gnb@sgi.com>
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
  • Loading branch information
Tom Tucker authored and J. Bruce Fields committed Feb 1, 2008
1 parent 9dbc240 commit eab996d
Showing 1 changed file with 7 additions and 9 deletions.
16 changes: 7 additions & 9 deletions net/sunrpc/svcsock.c
Original file line number Diff line number Diff line change
Expand Up @@ -368,18 +368,16 @@ void svc_reserve(struct svc_rqst *rqstp, int space)
}
}

static void
svc_sock_release(struct svc_rqst *rqstp)
static void svc_xprt_release(struct svc_rqst *rqstp)
{
struct svc_sock *svsk = rqstp->rq_sock;
struct svc_xprt *xprt = rqstp->rq_xprt;

rqstp->rq_xprt->xpt_ops->xpo_release_rqst(rqstp);

svc_free_res_pages(rqstp);
rqstp->rq_res.page_len = 0;
rqstp->rq_res.page_base = 0;


/* Reset response buffer and release
* the reservation.
* But first, check that enough space was reserved
Expand All @@ -392,9 +390,9 @@ svc_sock_release(struct svc_rqst *rqstp)

rqstp->rq_res.head[0].iov_len = 0;
svc_reserve(rqstp, 0);
rqstp->rq_sock = NULL;
rqstp->rq_xprt = NULL;

svc_xprt_put(&svsk->sk_xprt);
svc_xprt_put(xprt);
}

/*
Expand Down Expand Up @@ -1593,7 +1591,7 @@ svc_recv(struct svc_rqst *rqstp, long timeout)
/* No data, incomplete (TCP) read, or accept() */
if (len == 0 || len == -EAGAIN) {
rqstp->rq_res.len = 0;
svc_sock_release(rqstp);
svc_xprt_release(rqstp);
return -EAGAIN;
}
clear_bit(XPT_OLD, &svsk->sk_xprt.xpt_flags);
Expand All @@ -1613,7 +1611,7 @@ void
svc_drop(struct svc_rqst *rqstp)
{
dprintk("svc: socket %p dropped request\n", rqstp->rq_sock);
svc_sock_release(rqstp);
svc_xprt_release(rqstp);
}

/*
Expand Down Expand Up @@ -1646,7 +1644,7 @@ svc_send(struct svc_rqst *rqstp)
else
len = xprt->xpt_ops->xpo_sendto(rqstp);
mutex_unlock(&xprt->xpt_mutex);
svc_sock_release(rqstp);
svc_xprt_release(rqstp);

if (len == -ECONNREFUSED || len == -ENOTCONN || len == -EAGAIN)
return 0;
Expand Down

0 comments on commit eab996d

Please sign in to comment.