Skip to content

Commit

Permalink
cgroup: grab cgroup_mutex in drop_parsed_module_refcounts()
Browse files Browse the repository at this point in the history
This isn't strictly necessary as all subsystems specified in
@subsys_mask are guaranteed to be pinned; however, it does spuriously
trigger lockdep warning.  Let's grab cgroup_mutex around it.

Signed-off-by: Tejun Heo <tj@kernel.org>
Acked-by: Li Zefan <lizefan@huawei.com>
  • Loading branch information
Tejun Heo committed Jun 26, 2013
1 parent 1672d04 commit eb178d0
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions kernel/cgroup.c
Original file line number Diff line number Diff line change
Expand Up @@ -1325,11 +1325,11 @@ static void drop_parsed_module_refcounts(unsigned long subsys_mask)
struct cgroup_subsys *ss;
int i;

for_each_subsys(ss, i) {
if (!(subsys_mask & (1UL << i)))
continue;
module_put(cgroup_subsys[i]->module);
}
mutex_lock(&cgroup_mutex);
for_each_subsys(ss, i)
if (subsys_mask & (1UL << i))
module_put(cgroup_subsys[i]->module);
mutex_unlock(&cgroup_mutex);
}

static int cgroup_remount(struct super_block *sb, int *flags, char *data)
Expand Down

0 comments on commit eb178d0

Please sign in to comment.