Skip to content

Commit

Permalink
mfd: ab8500-debug: Add explicit dependencies
Browse files Browse the repository at this point in the history
As I am working on SPARSE_IRQ a number of implicit resource
grabs in the kernel become evident. For example, some includes
like <linux/irqs.h> would implicitly include <mach/irqs.h>
and then from there <mach/db8500-regs.h>.

In many cases it is masking the fact that drivers do not
properly use resources to pass their dependencies, base
addresses etc. So write explicit #include statements with
TODO items to have this fixed the proper way to all drivers
doing this.

Signed-off-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Reviewed-by: Philippe LANGLAIS <philippe.langlais@stericsson.com>
Acked-by: Samuel Ortiz <sameo@linux.intel.com>
  • Loading branch information
Linus Walleij authored and Lee Jones committed Mar 7, 2013
1 parent 9ee1767 commit eb1f958
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions drivers/mfd/ab8500-debugfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,9 @@
#include <linux/ctype.h>
#endif

/* TODO: this file should not reference IRQ_DB8500_AB8500! */
#include <mach/irqs.h>

static u32 debug_bank;
static u32 debug_address;

Expand Down

0 comments on commit eb1f958

Please sign in to comment.