Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 109413
b: refs/heads/master
c: 36fd71d
h: refs/heads/master
i:
  109411: 4eeff96
v: v3
  • Loading branch information
Li Zefan authored and Linus Torvalds committed Sep 3, 2008
1 parent 8450a09 commit eb8bdd1
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 09a2910e54646f7a334702fbafa7a6129dc072e6
refs/heads/master: 36fd71d293898a59b14e49da1f6e81c1a58f2035
18 changes: 9 additions & 9 deletions trunk/security/device_cgroup.c
Original file line number Diff line number Diff line change
Expand Up @@ -508,12 +508,11 @@ int devcgroup_inode_permission(struct inode *inode, int mask)
return 0;
if (!S_ISBLK(inode->i_mode) && !S_ISCHR(inode->i_mode))
return 0;
dev_cgroup = css_to_devcgroup(task_subsys_state(current,
devices_subsys_id));
if (!dev_cgroup)
return 0;

rcu_read_lock();

dev_cgroup = task_devcgroup(current);

list_for_each_entry_rcu(wh, &dev_cgroup->whitelist, list) {
if (wh->type & DEV_ALL)
goto acc_check;
Expand All @@ -533,6 +532,7 @@ int devcgroup_inode_permission(struct inode *inode, int mask)
rcu_read_unlock();
return 0;
}

rcu_read_unlock();

return -EPERM;
Expand All @@ -543,12 +543,10 @@ int devcgroup_inode_mknod(int mode, dev_t dev)
struct dev_cgroup *dev_cgroup;
struct dev_whitelist_item *wh;

dev_cgroup = css_to_devcgroup(task_subsys_state(current,
devices_subsys_id));
if (!dev_cgroup)
return 0;

rcu_read_lock();

dev_cgroup = task_devcgroup(current);

list_for_each_entry(wh, &dev_cgroup->whitelist, list) {
if (wh->type & DEV_ALL)
goto acc_check;
Expand All @@ -566,6 +564,8 @@ int devcgroup_inode_mknod(int mode, dev_t dev)
rcu_read_unlock();
return 0;
}

rcu_read_unlock();

return -EPERM;
}

0 comments on commit eb8bdd1

Please sign in to comment.