Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 290663
b: refs/heads/master
c: f6fd51d
h: refs/heads/master
i:
  290661: c9fee36
  290659: 359bc0a
  290655: 8a374d5
v: v3
  • Loading branch information
Don Fry authored and Wey-Yi Guy committed Feb 17, 2012
1 parent 8d76f46 commit eba010d
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 13 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: d359667767e845d86f60a4ea6374ccb6b8fe0ce5
refs/heads/master: f6fd51d9a5abc9aa90246ddc82bbca376c06462e
1 change: 0 additions & 1 deletion trunk/drivers/net/wireless/iwlwifi/iwl-dev.h
Original file line number Diff line number Diff line change
Expand Up @@ -788,7 +788,6 @@ struct iwl_priv {
struct mac_address addresses[2];

/* uCode images, save to reload in case of failure */
int fw_index; /* firmware we're trying to load */
char firmware_name[25];

struct iwl_rxon_context contexts[NUM_IWL_RXON_CTX];
Expand Down
23 changes: 12 additions & 11 deletions trunk/drivers/net/wireless/iwlwifi/iwl-ucode.c
Original file line number Diff line number Diff line change
Expand Up @@ -690,31 +690,32 @@ static void iwl_ucode_callback(const struct firmware *ucode_raw, void *context);

int __must_check iwl_request_firmware(struct iwl_priv *priv, bool first)
{
struct iwl_nic *nic = nic(priv);
const char *name_pre = cfg(priv)->fw_name_pre;
char tag[8];

if (first) {
#ifdef CONFIG_IWLWIFI_DEBUG_EXPERIMENTAL_UCODE
priv->fw_index = UCODE_EXPERIMENTAL_INDEX;
nic->fw_index = UCODE_EXPERIMENTAL_INDEX;
strcpy(tag, UCODE_EXPERIMENTAL_TAG);
} else if (priv->fw_index == UCODE_EXPERIMENTAL_INDEX) {
} else if (nic->fw_index == UCODE_EXPERIMENTAL_INDEX) {
#endif
priv->fw_index = cfg(priv)->ucode_api_max;
sprintf(tag, "%d", priv->fw_index);
nic->fw_index = cfg(priv)->ucode_api_max;
sprintf(tag, "%d", nic->fw_index);
} else {
priv->fw_index--;
sprintf(tag, "%d", priv->fw_index);
nic->fw_index--;
sprintf(tag, "%d", nic->fw_index);
}

if (priv->fw_index < cfg(priv)->ucode_api_min) {
if (nic->fw_index < cfg(priv)->ucode_api_min) {
IWL_ERR(priv, "no suitable firmware found!\n");
return -ENOENT;
}

sprintf(priv->firmware_name, "%s%s%s", name_pre, tag, ".ucode");

IWL_DEBUG_INFO(priv, "attempting to load firmware %s'%s'\n",
(priv->fw_index == UCODE_EXPERIMENTAL_INDEX)
(nic->fw_index == UCODE_EXPERIMENTAL_INDEX)
? "EXPERIMENTAL " : "",
priv->firmware_name);

Expand Down Expand Up @@ -1032,7 +1033,7 @@ static void iwl_ucode_callback(const struct firmware *ucode_raw, void *context)
memset(&pieces, 0, sizeof(pieces));

if (!ucode_raw) {
if (priv->fw_index <= api_ok)
if (nic->fw_index <= api_ok)
IWL_ERR(priv,
"request for firmware file '%s' failed.\n",
priv->firmware_name);
Expand Down Expand Up @@ -1069,7 +1070,7 @@ static void iwl_ucode_callback(const struct firmware *ucode_raw, void *context)
* on the API version read from firmware header from here on forward
*/
/* no api version check required for experimental uCode */
if (priv->fw_index != UCODE_EXPERIMENTAL_INDEX) {
if (nic->fw_index != UCODE_EXPERIMENTAL_INDEX) {
if (api_ver < api_min || api_ver > api_max) {
IWL_ERR(priv,
"Driver unable to support your firmware API. "
Expand All @@ -1094,7 +1095,7 @@ static void iwl_ucode_callback(const struct firmware *ucode_raw, void *context)

if (build)
sprintf(buildstr, " build %u%s", build,
(priv->fw_index == UCODE_EXPERIMENTAL_INDEX)
(nic->fw_index == UCODE_EXPERIMENTAL_INDEX)
? " (EXP)" : "");
else
buildstr[0] = '\0';
Expand Down

0 comments on commit eba010d

Please sign in to comment.