Skip to content

Commit

Permalink
V4L/DVB (3312): FIX: Multiple usage of VP7045-based devices
Browse files Browse the repository at this point in the history
Reassigning function pointers in a static led to infinite loops when using
multiple VP7045-based device at the same time on one system. Using kmalloc'd
copies for reassignments is better.

Signed-off-by: Patrick Boettcher <pb@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
  • Loading branch information
Patrick Boettcher authored and Mauro Carvalho Chehab committed Feb 7, 2006
1 parent 6363136 commit eba841e
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions drivers/media/dvb/dvb-usb/vp7045-fe.c
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,11 @@

struct vp7045_fe_state {
struct dvb_frontend fe;
struct dvb_frontend_ops ops;

struct dvb_usb_device *d;
};


static int vp7045_fe_read_status(struct dvb_frontend* fe, fe_status_t *status)
{
struct vp7045_fe_state *state = fe->demodulator_priv;
Expand Down Expand Up @@ -150,7 +151,8 @@ struct dvb_frontend * vp7045_fe_attach(struct dvb_usb_device *d)
goto error;

s->d = d;
s->fe.ops = &vp7045_fe_ops;
memcpy(&s->ops, &vp7045_fe_ops, sizeof(struct dvb_frontend_ops));
s->fe.ops = &s->ops;
s->fe.demodulator_priv = s;

goto success;
Expand Down

0 comments on commit eba841e

Please sign in to comment.