Skip to content

Commit

Permalink
9p: do no return 0 from ->check_acl without actually checking
Browse files Browse the repository at this point in the history
If we do not want to use ACLs we at least need to perform normal Unix
permission checks.  From the comment I'm not quite sure that's what
is intended, but if 0p wants to do permission checks entirely on the
server it needs to do so in ->permission, not in ->check_acl.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
  • Loading branch information
Christoph Hellwig authored and Al Viro committed Jul 25, 2011
1 parent e77819e commit ebbb0ef
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fs/9p/acl.c
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ int v9fs_check_acl(struct inode *inode, int mask)
* On access = client and acl = on mode get the acl
* values from the server
*/
return 0;
return -EAGAIN;
}
acl = v9fs_get_cached_acl(inode, ACL_TYPE_ACCESS);

Expand Down

0 comments on commit ebbb0ef

Please sign in to comment.