Skip to content

Commit

Permalink
[SCSI] fix transport class corner case after rework
Browse files Browse the repository at this point in the history
If your transport class sets the ATTRIBUTE_CONTAINER_NO_CLASSDEVS flag,
then its configure method never gets called.  This patch fixes that so
that the configure method is called with a NULL classdev.

Also remove a spurious inverted comma in the transport_class comments.

Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
  • Loading branch information
James Bottomley authored and James Bottomley committed Aug 28, 2005
1 parent 975f24b commit ebd8bb7
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions drivers/base/attribute_container.c
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,11 @@ attribute_container_device_trigger(struct device *dev,
if (!cont->match(cont, dev))
continue;

if (attribute_container_no_classdevs(cont)) {
fn(cont, dev, NULL);
continue;
}

spin_lock(&cont->containers_lock);
list_for_each_entry_safe(ic, tmp, &cont->containers, node) {
if (dev == ic->classdev.dev)
Expand Down
2 changes: 1 addition & 1 deletion drivers/base/transport_class.c
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* This file is licensed under GPLv2
*
* The basic idea here is to allow any "device controller" (which
* would most often be a Host Bus Adapter" to use the services of one
* would most often be a Host Bus Adapter to use the services of one
* or more tranport classes for performing transport specific
* services. Transport specific services are things that the generic
* command layer doesn't want to know about (speed settings, line
Expand Down

0 comments on commit ebd8bb7

Please sign in to comment.