Skip to content

Commit

Permalink
watchdog: wm8350_wdt: Fix handling WDIOS_DISABLECARD/WDIOS_ENABLECARD…
Browse files Browse the repository at this point in the history
… options

While receiving WDIOS_DISABLECARD option for WDIOC_SETOPTIONS command,
call wm8350_wdt_stop() to disable watchdog.
Call wm8350_wdt_start() while receiving WDIOS_ENABLECARD option.

Current code has reverse behavior.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
  • Loading branch information
Axel Lin authored and Wim Van Sebroeck committed Jan 27, 2012
1 parent 2865e77 commit ebe06e8
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/watchdog/wm8350_wdt.c
Original file line number Diff line number Diff line change
Expand Up @@ -212,10 +212,10 @@ static long wm8350_wdt_ioctl(struct file *file, unsigned int cmd,

/* Setting both simultaneously means at least one must fail */
if (options == WDIOS_DISABLECARD)
ret = wm8350_wdt_start(wm8350);
ret = wm8350_wdt_stop(wm8350);

if (options == WDIOS_ENABLECARD)
ret = wm8350_wdt_stop(wm8350);
ret = wm8350_wdt_start(wm8350);
break;
}

Expand Down

0 comments on commit ebe06e8

Please sign in to comment.