Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 25340
b: refs/heads/master
c: 49c93e8
h: refs/heads/master
v: v3
  • Loading branch information
Andi Kleen authored and Linus Torvalds committed Apr 9, 2006
1 parent b381421 commit ebeec2d
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 4 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 8c30b1a74aed4041f183e183a149b7dfbdc6c20e
refs/heads/master: 49c93e84d8b2d602a07c302c7e3cd4fa09095fbb
4 changes: 3 additions & 1 deletion trunk/arch/i386/pci/direct.c
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,10 @@ int pci_conf1_read(unsigned int seg, unsigned int bus,
{
unsigned long flags;

if (!value || (bus > 255) || (devfn > 255) || (reg > 255))
if (!value || (bus > 255) || (devfn > 255) || (reg > 255)) {
*value = -1;
return -EINVAL;
}

spin_lock_irqsave(&pci_config_lock, flags);

Expand Down
4 changes: 3 additions & 1 deletion trunk/arch/i386/pci/mmconfig.c
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,10 @@ static int pci_mmcfg_read(unsigned int seg, unsigned int bus,
unsigned long flags;
u32 base;

if (!value || (bus > 255) || (devfn > 255) || (reg > 4095))
if (!value || (bus > 255) || (devfn > 255) || (reg > 4095)) {
*value = -1;
return -EINVAL;
}

base = get_base_addr(seg, bus, devfn);
if (!base)
Expand Down
4 changes: 3 additions & 1 deletion trunk/arch/x86_64/pci/mmconfig.c
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,10 @@ static int pci_mmcfg_read(unsigned int seg, unsigned int bus,
char __iomem *addr;

/* Why do we have this when nobody checks it. How about a BUG()!? -AK */
if (unlikely(!value || (bus > 255) || (devfn > 255) || (reg > 4095)))
if (unlikely(!value || (bus > 255) || (devfn > 255) || (reg > 4095))) {
*value = -1;
return -EINVAL;
}

addr = pci_dev_base(seg, bus, devfn);
if (!addr)
Expand Down

0 comments on commit ebeec2d

Please sign in to comment.