Skip to content

Commit

Permalink
PCI: rpaphp: remove a call that does nothing but a pointer lookup
Browse files Browse the repository at this point in the history
Delete another stovepipe: a call to a routine which does nothing.
Remove un-needed semaphore as well.

Signed-off-by: Linas Vepstas <linas@austin.ibm.com>
Cc: John Rose <johnrose@austin.ibm.com>
Signed-off-by: Kristen Carlson Accardi <kristen.c.accardi@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Linas Vepstas authored and Greg Kroah-Hartman committed May 3, 2007
1 parent bf0af51 commit ebf42c0
Showing 1 changed file with 2 additions and 15 deletions.
17 changes: 2 additions & 15 deletions drivers/pci/hotplug/rpaphp_core.c
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,6 @@ MODULE_LICENSE("GPL");

module_param(debug, bool, 0644);

static int rpaphp_get_attention_status(struct slot *slot)
{
return slot->hotplug_slot->info->attention_status;
}

/**
* set_attention_status - set attention LED
* echo 0 > attention -- set LED OFF
Expand Down Expand Up @@ -95,8 +90,6 @@ static int set_attention_status(struct hotplug_slot *hotplug_slot, u8 value)
* get_power_status - get power status of a slot
* @hotplug_slot: slot to get status
* @value: pointer to store status
*
*
*/
static int get_power_status(struct hotplug_slot *hotplug_slot, u8 * value)
{
Expand All @@ -113,18 +106,12 @@ static int get_power_status(struct hotplug_slot *hotplug_slot, u8 * value)

/**
* get_attention_status - get attention LED status
*
*
*/
static int get_attention_status(struct hotplug_slot *hotplug_slot, u8 * value)
{
int retval = 0;
struct slot *slot = (struct slot *)hotplug_slot->private;

down(&rpaphp_sem);
*value = rpaphp_get_attention_status(slot);
up(&rpaphp_sem);
return retval;
*value = slot->hotplug_slot->info->attention_status;
return 0;
}

static int get_adapter_status(struct hotplug_slot *hotplug_slot, u8 * value)
Expand Down

0 comments on commit ebf42c0

Please sign in to comment.