Skip to content

Commit

Permalink
ep93xx: some minor cleanups to the ep93xx eth driver
Browse files Browse the repository at this point in the history
Small cleanup in the Cirrus Logic EP93xx ethernet driver: Check for NULL
pointer before dereferencing it instead of after.  Remove unreferenced
variable.

Signed-off-by: Yan Burman <burman.yan@gmail.com>
Cc: Jeff Garzik <jeff@garzik.org>
Cc: Russell King <rmk@arm.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
  • Loading branch information
Yan Burman authored and Jeff Garzik committed Dec 26, 2006
1 parent 3a960f7 commit ebf5112
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions drivers/net/arm/ep93xx_eth.c
Original file line number Diff line number Diff line change
Expand Up @@ -780,12 +780,10 @@ static struct ethtool_ops ep93xx_ethtool_ops = {
struct net_device *ep93xx_dev_alloc(struct ep93xx_eth_data *data)
{
struct net_device *dev;
struct ep93xx_priv *ep;

dev = alloc_etherdev(sizeof(struct ep93xx_priv));
if (dev == NULL)
return NULL;
ep = netdev_priv(dev);

memcpy(dev->dev_addr, data->dev_addr, ETH_ALEN);

Expand Down Expand Up @@ -840,9 +838,9 @@ static int ep93xx_eth_probe(struct platform_device *pdev)
struct ep93xx_priv *ep;
int err;

data = pdev->dev.platform_data;
if (pdev == NULL)
return -ENODEV;
data = pdev->dev.platform_data;

dev = ep93xx_dev_alloc(data);
if (dev == NULL) {
Expand Down

0 comments on commit ebf5112

Please sign in to comment.