Skip to content

Commit

Permalink
UBIFS: dump the stack on errors in failure mode too
Browse files Browse the repository at this point in the history
When UBIFS is in the failure mode (used for power cut emulation testing) we for
some reasons do not dump the stack in many places, e.g., in assertions.
Probably at early days we had too many of them and disabled this to make the
development easier, but then never enabled. Nowadays I sometimes observe
assertion failures during power cut testing, but the useful stackdump is not
printed, which is bad. This patch makes UBIFS always print the stackdump when
debugging is enabled.

Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
  • Loading branch information
Artem Bityutskiy authored and Artem Bityutskiy committed May 13, 2011
1 parent 6d5904e commit ec06814
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions fs/ubifs/debug.h
Original file line number Diff line number Diff line change
Expand Up @@ -107,10 +107,7 @@ struct ubifs_debug_info {
} \
} while (0)

#define dbg_dump_stack() do { \
if (!dbg_failure_mode) \
dump_stack(); \
} while (0)
#define dbg_dump_stack() dump_stack()

/* Generic debugging messages */
#define dbg_msg(fmt, ...) do { \
Expand Down

0 comments on commit ec06814

Please sign in to comment.