Skip to content

Commit

Permalink
libceph: drop connection refcounting for mon_client
Browse files Browse the repository at this point in the history
All references to the embedded ceph_connection come from the msgr
workqueue, which is drained prior to mon_client destruction.  That
means we can ignore con refcounting entirely.

Signed-off-by: Sage Weil <sage@newdream.net>
Reviewed-by: Alex Elder <elder@inktank.com>
  • Loading branch information
Sage Weil authored and Alex Elder committed Jun 6, 2012
1 parent 6713093 commit ec87ef4
Showing 1 changed file with 16 additions and 2 deletions.
18 changes: 16 additions & 2 deletions net/ceph/mon_client.c
Original file line number Diff line number Diff line change
Expand Up @@ -1029,9 +1029,23 @@ static void mon_fault(struct ceph_connection *con)
mutex_unlock(&monc->mutex);
}

/*
* We can ignore refcounting on the connection struct, as all references
* will come from the messenger workqueue, which is drained prior to
* mon_client destruction.
*/
static struct ceph_connection *con_get(struct ceph_connection *con)
{
return con;
}

static void con_put(struct ceph_connection *con)
{
}

static const struct ceph_connection_operations mon_con_ops = {
.get = ceph_con_get,
.put = ceph_con_put,
.get = con_get,
.put = con_put,
.dispatch = dispatch,
.fault = mon_fault,
.alloc_msg = mon_alloc_msg,
Expand Down

0 comments on commit ec87ef4

Please sign in to comment.