Skip to content

Commit

Permalink
[media] cx24120: constify static data
Browse files Browse the repository at this point in the history
Use const on the static data, as gcc may optimize better the
code. Also, would prevent that some code would override the
data there.

Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Signed-off-by: Patrick Boettcher <patrick.boettcher@posteo.de>
  • Loading branch information
Mauro Carvalho Chehab committed May 20, 2015
1 parent 5b8bc80 commit ec8fe6c
Showing 1 changed file with 12 additions and 6 deletions.
18 changes: 12 additions & 6 deletions drivers/media/dvb-frontends/cx24120.c
Original file line number Diff line number Diff line change
Expand Up @@ -704,12 +704,14 @@ static int cx24120_read_status(struct dvb_frontend *fe, fe_status_t *status)
* Used for decoding the REG_FECMODE register
* once tuned in.
*/
static struct cx24120_modfec {
struct cx24120_modfec {
fe_delivery_system_t delsys;
fe_modulation_t mod;
fe_code_rate_t fec;
u8 val;
} modfec_lookup_table[] = {
};

static const struct cx24120_modfec modfec_lookup_table[] = {
/*delsys mod fec val */
{ SYS_DVBS, QPSK, FEC_1_2, 0x01 },
{ SYS_DVBS, QPSK, FEC_2_3, 0x02 },
Expand Down Expand Up @@ -784,15 +786,17 @@ static int cx24120_get_fec(struct dvb_frontend *fe)
* There's probably some way of calculating these but I
* can't determine the pattern
*/
static struct cx24120_clock_ratios_table {
struct cx24120_clock_ratios_table {
fe_delivery_system_t delsys;
fe_pilot_t pilot;
fe_modulation_t mod;
fe_code_rate_t fec;
u32 m_rat;
u32 n_rat;
u32 rate;
} clock_ratios_table[] = {
};

static const struct cx24120_clock_ratios_table clock_ratios_table[] = {
/*delsys pilot mod fec m_rat n_rat rate */
{ SYS_DVBS2, PILOT_OFF, QPSK, FEC_1_2, 273088, 254505, 274 },
{ SYS_DVBS2, PILOT_OFF, QPSK, FEC_3_5, 17272, 13395, 330 },
Expand Down Expand Up @@ -921,12 +925,14 @@ static int cx24120_set_inversion(struct cx24120_state *state,
}

/* FEC lookup table for tuning */
static struct cx24120_modfec_table {
struct cx24120_modfec_table {
fe_delivery_system_t delsys;
fe_modulation_t mod;
fe_code_rate_t fec;
u8 val;
} modfec_table[] = {
};

static const struct cx24120_modfec_table modfec_table[] = {
/*delsys mod fec val */
{ SYS_DVBS, QPSK, FEC_1_2, 0x2e },
{ SYS_DVBS, QPSK, FEC_2_3, 0x2f },
Expand Down

0 comments on commit ec8fe6c

Please sign in to comment.