Skip to content

Commit

Permalink
[PATCH] ARM: Cleanup kmalloc in cyber2000fb
Browse files Browse the repository at this point in the history
We use one kmalloc to allocate two structures needlessly.
Combine these two structures into one.

Signed-off-by: Russell King <rmk@arm.linux.org.uk>
  • Loading branch information
Russell King committed May 3, 2005
1 parent 1f9c381 commit eca02b0
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions drivers/video/cyber2000fb.c
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,8 @@ struct cfb_info {
*/
u_char ramdac_ctrl;
u_char ramdac_powerdown;

u32 pseudo_palette[16];
};

static char *default_font = "Acorn8x8";
Expand Down Expand Up @@ -1223,9 +1225,7 @@ cyberpro_alloc_fb_info(unsigned int id, char *name)
{
struct cfb_info *cfb;

cfb = kmalloc(sizeof(struct cfb_info) +
sizeof(u32) * 16, GFP_KERNEL);

cfb = kmalloc(sizeof(struct cfb_info), GFP_KERNEL);
if (!cfb)
return NULL;

Expand Down Expand Up @@ -1281,7 +1281,7 @@ cyberpro_alloc_fb_info(unsigned int id, char *name)

cfb->fb.fbops = &cyber2000fb_ops;
cfb->fb.flags = FBINFO_DEFAULT | FBINFO_HWACCEL_YPAN;
cfb->fb.pseudo_palette = (void *)(cfb + 1);
cfb->fb.pseudo_palette = cfb->pseudo_palette;

fb_alloc_cmap(&cfb->fb.cmap, NR_PALETTE, 0);

Expand Down

0 comments on commit eca02b0

Please sign in to comment.