Skip to content

Commit

Permalink
ps3fb: atomic fixes
Browse files Browse the repository at this point in the history
ps3fb: Use atomic_dec_if_positive() instead of bogus atomic_read()/atomic_dec()
combinations

Signed-off-by: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Geert Uytterhoeven authored and Linus Torvalds committed May 5, 2007
1 parent 1c0c846 commit eca2874
Showing 1 changed file with 4 additions and 8 deletions.
12 changes: 4 additions & 8 deletions drivers/video/ps3fb.c
Original file line number Diff line number Diff line change
Expand Up @@ -680,13 +680,10 @@ EXPORT_SYMBOL_GPL(ps3fb_wait_for_vsync);

void ps3fb_flip_ctl(int on)
{
if (on) {
if (atomic_read(&ps3fb.ext_flip) > 0) {
atomic_dec(&ps3fb.ext_flip);
}
} else {
if (on)
atomic_dec_if_positive(&ps3fb.ext_flip);
else
atomic_inc(&ps3fb.ext_flip);
}
}

EXPORT_SYMBOL_GPL(ps3fb_flip_ctl);
Expand Down Expand Up @@ -786,8 +783,7 @@ static int ps3fb_ioctl(struct fb_info *info, unsigned int cmd,

case PS3FB_IOCTL_OFF:
DPRINTK("PS3FB_IOCTL_OFF:\n");
if (atomic_read(&ps3fb.ext_flip) > 0)
atomic_dec(&ps3fb.ext_flip);
atomic_dec_if_positive(&ps3fb.ext_flip);
retval = 0;
break;

Expand Down

0 comments on commit eca2874

Please sign in to comment.