Skip to content

Commit

Permalink
m68knommu: fix size of address field for 5272 interrupt controller
Browse files Browse the repository at this point in the history
Picked up by the 0-day buidler:

All warnings:
>> arch/m68k/coldfire/intc-5272.c:46:20: warning: large integer implicitly truncated to unsigned type [-Woverflow]
     /*MCF_IRQ_EINT1*/ { .icr = MCFSIM_ICR1, .index = 28, .ack = 1, },
...

The problem stems from the changes to make all ColdFire register addresses
absolute, in commit d72a5ab ("make remaining ColdFire 5272 register
definitions absolute"). That change did not take into account that the
addresses were stored as offsets in the irqmap of the intc-5272.c code.
Make the field that now stores register addresses big enough to hold
addresses.

Signed-off-by: Greg Ungerer <gerg@uclinux.org>
  • Loading branch information
Greg Ungerer committed Sep 28, 2014
1 parent 6f4a885 commit ecb6bdc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion arch/m68k/coldfire/intc-5272.c
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
* they also need acknowledging via acknowledge bits.
*/
struct irqmap {
unsigned char icr;
unsigned int icr;
unsigned char index;
unsigned char ack;
};
Expand Down

0 comments on commit ecb6bdc

Please sign in to comment.