Skip to content

Commit

Permalink
usb: host: tegra: fix warning messages in ehci_remove
Browse files Browse the repository at this point in the history
Existing implementation of tegra_ehci_remove() calls
usb_put_hcd(hcd) first and then iounmap(hcd->regs).

usb_put_hcd() implementation calls hcd_release()
which frees up memory allocated for hcd.

As iounmap is trying to unmap hcd->regs, after hcd
getting freed up, warning messages were observed during
unload of USB.

Hence fixing it.

Signed-off-by: Venu Byravarasu <vbyravarasu@nvidia.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Venu Byravarasu authored and Greg Kroah-Hartman committed Aug 10, 2012
1 parent cc59c7a commit ecc8a0c
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion drivers/usb/host/ehci-tegra.c
Original file line number Diff line number Diff line change
Expand Up @@ -799,11 +799,12 @@ static int tegra_ehci_remove(struct platform_device *pdev)
#endif

usb_remove_hcd(hcd);
usb_put_hcd(hcd);

tegra_usb_phy_close(tegra->phy);
iounmap(hcd->regs);

usb_put_hcd(hcd);

clk_disable_unprepare(tegra->clk);
clk_put(tegra->clk);

Expand Down

0 comments on commit ecc8a0c

Please sign in to comment.