Skip to content

Commit

Permalink
[POWERPC] spufs: use kzalloc in create_spu
Browse files Browse the repository at this point in the history
Clean up create_spu() a little by using kzalloc instead of kmalloc +
assignments.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Signed-off-by: Arnd Bergmann <arnd.bergmann@de.ibm.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>
  • Loading branch information
Jeremy Kerr authored and Paul Mackerras committed Jun 21, 2006
1 parent 970f1ba commit ecec217
Showing 1 changed file with 2 additions and 19 deletions.
21 changes: 2 additions & 19 deletions arch/powerpc/platforms/cell/spu_base.c
Original file line number Diff line number Diff line change
Expand Up @@ -701,7 +701,7 @@ static int __init create_spu(struct device_node *spe)
static int number;

ret = -ENOMEM;
spu = kmalloc(sizeof (*spu), GFP_KERNEL);
spu = kzalloc(sizeof (*spu), GFP_KERNEL);
if (!spu)
goto out;

Expand All @@ -713,28 +713,11 @@ static int __init create_spu(struct device_node *spe)
spu->nid = of_node_to_nid(spe);
if (spu->nid == -1)
spu->nid = 0;

spu->stop_code = 0;
spu->slb_replace = 0;
spu->mm = NULL;
spu->ctx = NULL;
spu->rq = NULL;
spu->pid = 0;
spu->class_0_pending = 0;
spu->flags = 0UL;
spu->dar = 0UL;
spu->dsisr = 0UL;
spin_lock_init(&spu->register_lock);

spu_mfc_sdr_set(spu, mfspr(SPRN_SDR1));
spu_mfc_sr1_set(spu, 0x33);

spu->ibox_callback = NULL;
spu->wbox_callback = NULL;
spu->stop_callback = NULL;
spu->mfc_callback = NULL;

mutex_lock(&spu_mutex);

spu->number = number++;
ret = spu_request_irqs(spu);
if (ret)
Expand Down

0 comments on commit ecec217

Please sign in to comment.