Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 3290
b: refs/heads/master
c: cafb20c
h: refs/heads/master
v: v3
  • Loading branch information
Nick Piggin authored and Linus Torvalds committed Jun 25, 2005
1 parent 5581b08 commit ed123fc
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 23 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: a3f21bce1fefdf92a4d1705e888d390b10f3ac6f
refs/heads/master: cafb20c1f9976a70d633bb1e1c8c24eab00e4e80
1 change: 0 additions & 1 deletion trunk/include/asm-i386/topology.h
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ static inline int node_to_first_cpu(int node)
.flags = SD_LOAD_BALANCE \
| SD_BALANCE_EXEC \
| SD_BALANCE_NEWIDLE \
| SD_WAKE_IDLE \
| SD_WAKE_BALANCE, \
.last_balance = jiffies, \
.balance_interval = 1, \
Expand Down
1 change: 0 additions & 1 deletion trunk/include/asm-x86_64/topology.h
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ extern int __node_distance(int, int);
.flags = SD_LOAD_BALANCE \
| SD_BALANCE_NEWIDLE \
| SD_BALANCE_EXEC \
| SD_WAKE_IDLE \
| SD_WAKE_BALANCE, \
.last_balance = jiffies, \
.balance_interval = 1, \
Expand Down
1 change: 0 additions & 1 deletion trunk/include/linux/topology.h
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,6 @@
| SD_BALANCE_NEWIDLE \
| SD_BALANCE_EXEC \
| SD_WAKE_AFFINE \
| SD_WAKE_IDLE \
| SD_WAKE_BALANCE, \
.last_balance = jiffies, \
.balance_interval = 1, \
Expand Down
21 changes: 2 additions & 19 deletions trunk/kernel/sched.c
Original file line number Diff line number Diff line change
Expand Up @@ -414,22 +414,6 @@ static inline runqueue_t *this_rq_lock(void)
return rq;
}

#ifdef CONFIG_SCHED_SMT
static int cpu_and_siblings_are_idle(int cpu)
{
int sib;
for_each_cpu_mask(sib, cpu_sibling_map[cpu]) {
if (idle_cpu(sib))
continue;
return 0;
}

return 1;
}
#else
#define cpu_and_siblings_are_idle(A) idle_cpu(A)
#endif

#ifdef CONFIG_SCHEDSTATS
/*
* Called when a process is dequeued from the active array and given
Expand Down Expand Up @@ -1652,12 +1636,11 @@ int can_migrate_task(task_t *p, runqueue_t *rq, int this_cpu,

/*
* Aggressive migration if:
* 1) the [whole] cpu is idle, or
* 1) task is cache cold, or
* 2) too many balance attempts have failed.
*/

if (cpu_and_siblings_are_idle(this_cpu) || \
sd->nr_balance_failed > sd->cache_nice_tries)
if (sd->nr_balance_failed > sd->cache_nice_tries)
return 1;

if (task_hot(p, rq->timestamp_last_tick, sd))
Expand Down

0 comments on commit ed123fc

Please sign in to comment.