Skip to content

Commit

Permalink
[PATCH] m68k: fix macfb init
Browse files Browse the repository at this point in the history
To be used by module_init() function should return int; same for functions
that have "return -ENODEV;" in them, actually ;-)

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Cc: Roman Zippel <zippel@linux-m68k.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Al Viro authored and Linus Torvalds committed Jan 12, 2006
1 parent 54a5a6e commit ed1705a
Showing 1 changed file with 8 additions and 7 deletions.
15 changes: 8 additions & 7 deletions drivers/video/macfb.c
Original file line number Diff line number Diff line change
Expand Up @@ -609,18 +609,19 @@ void __init macfb_setup(char *options)
}
}

void __init macfb_init(void)
static int __init macfb_init(void)
{
int video_cmap_len, video_is_nubus = 0;
struct nubus_dev* ndev = NULL;
char *option = NULL;
int err;

if (fb_get_options("macfb", &option))
return -ENODEV;
macfb_setup(option);

if (!MACH_IS_MAC)
return;
return -ENODEV;

/* There can only be one internal video controller anyway so
we're not too worried about this */
Expand Down Expand Up @@ -958,11 +959,11 @@ void __init macfb_init(void)

fb_alloc_cmap(&fb_info.cmap, video_cmap_len, 0);

if (register_framebuffer(&fb_info) < 0)
return;

printk("fb%d: %s frame buffer device\n",
fb_info.node, fb_info.fix.id);
err = register_framebuffer(&fb_info);
if (!err)
printk("fb%d: %s frame buffer device\n",
fb_info.node, fb_info.fix.id);
return err;
}

module_init(macfb_init);
Expand Down

0 comments on commit ed1705a

Please sign in to comment.