Skip to content

Commit

Permalink
[CIFS] Do not log path names in lookup errors
Browse files Browse the repository at this point in the history
Andi Kleen noticed that we were logging access denied errors (which is
noisy in the dmesg log, and not needed to be logged) and that we were
logging path names on that an other errors (e.g. EIO) which we should
not be doing.

CC: Andi Kleen <ak@suse.de>
Signed-off-by: Steve French <sfrench@us.ibm.com>
  • Loading branch information
Steve French committed Jan 20, 2008
1 parent e6ab158 commit ed2b917
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions fs/cifs/dir.c
Original file line number Diff line number Diff line change
Expand Up @@ -517,12 +517,10 @@ cifs_lookup(struct inode *parent_dir_inode, struct dentry *direntry,
d_add(direntry, NULL);
/* if it was once a directory (but how can we tell?) we could do
shrink_dcache_parent(direntry); */
} else {
cERROR(1, ("Error 0x%x on cifs_get_inode_info in lookup of %s",
rc, full_path));
/* BB special case check for Access Denied - watch security
exposure of returning dir info implicitly via different rc
if file exists or not but no access BB */
} else if (rc != -EACCES) {
cERROR(1, ("Unexpected lookup error %d", rc));
/* We special case check for Access Denied - since that
is a common return code */
}

kfree(full_path);
Expand Down

0 comments on commit ed2b917

Please sign in to comment.