Skip to content

Commit

Permalink
team: forbid incorrect fall-through in notifier
Browse files Browse the repository at this point in the history
There are two breaks missing there. The result is that userspace
receives multiple messages which might be confusing.

Introduced-by: 3d249d4 "net: introduce ethernet teaming device"
Signed-off-by: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Jiri Pirko authored and David S. Miller committed Apr 24, 2014
1 parent 8ea2b17 commit ed2da03
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions drivers/net/team/team.c
Original file line number Diff line number Diff line change
Expand Up @@ -2834,8 +2834,10 @@ static int team_device_event(struct notifier_block *unused,
case NETDEV_UP:
if (netif_carrier_ok(dev))
team_port_change_check(port, true);
break;
case NETDEV_DOWN:
team_port_change_check(port, false);
break;
case NETDEV_CHANGE:
if (netif_running(port->dev))
team_port_change_check(port,
Expand Down

0 comments on commit ed2da03

Please sign in to comment.