Skip to content

Commit

Permalink
xfs: Return -EIO when xfs_vn_getattr() failed
Browse files Browse the repository at this point in the history
An attribute of inode can be fetched via xfs_vn_getattr() in XFS.
Currently it returns EIO, not negative value, when it failed.  As a
result, the system call returns not negative value even though an
error occured. The stat(2), ls and mv commands cannot handle this
error and do not work correctly.

This patch fixes this bug, and returns -EIO, not EIO when an error
is detected in xfs_vn_getattr().

Signed-off-by: Mitsuo Hayasaka <mitsuo.hayasaka.hu@hitachi.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Alex Elder <aelder@sgi.com>
  • Loading branch information
Mitsuo Hayasaka authored and Alex Elder committed Oct 12, 2011
1 parent eabbaf1 commit ed32201
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fs/xfs/xfs_iops.c
Original file line number Diff line number Diff line change
Expand Up @@ -465,7 +465,7 @@ xfs_vn_getattr(
trace_xfs_getattr(ip);

if (XFS_FORCED_SHUTDOWN(mp))
return XFS_ERROR(EIO);
return -XFS_ERROR(EIO);

stat->size = XFS_ISIZE(ip);
stat->dev = inode->i_sb->s_dev;
Expand Down

0 comments on commit ed32201

Please sign in to comment.