Skip to content

Commit

Permalink
[ACPI] fix pnpacpi regression resulting from ACPICA 20051117
Browse files Browse the repository at this point in the history
In ACPICA 20051117, acpi_walk_resources() started
sending ACPI_RESOURCE_TYPE_END_TAG to the callback
routine which wasn't prepared for it, causing
_CRS to fail and PnPACPI to not recognize any devices:

pnp: ACPI device : hid PNP0C02
pnp: PnPACPI: unknown resource type 7
pnp: PnPACPI: METHOD_NAME__CRS failure for PNP0c02

Signed-off-by: Len Brown <len.brown@intel.com>
  • Loading branch information
Len Brown committed Jan 5, 2006
1 parent 3173cdf commit ed349a8
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions drivers/acpi/resources/rsxface.c
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,12 @@ acpi_walk_resources(acpi_handle device_handle,
break;
}

/* end_tag indicates end-of-list */

if (resource->type == ACPI_RESOURCE_TYPE_END_TAG) {
break;
}

/* Invoke the user function, abort on any error returned */

status = user_function(resource, context);
Expand All @@ -298,12 +304,6 @@ acpi_walk_resources(acpi_handle device_handle,
break;
}

/* end_tag indicates end-of-list */

if (resource->type == ACPI_RESOURCE_TYPE_END_TAG) {
break;
}

/* Get the next resource descriptor */

resource =
Expand Down

0 comments on commit ed349a8

Please sign in to comment.